Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes for unimplemented CSS mask-origin keywords #6949

Merged
merged 4 commits into from
Apr 9, 2021
Merged

Add notes for unimplemented CSS mask-origin keywords #6949

merged 4 commits into from
Apr 9, 2021

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 16, 2020
rachelandrew
rachelandrew reviewed Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec containing these (CSS Masking) is a Candidate Recommendation so it is unlikely they will be removed, masking has fairly patchy implementation I think.

@saschanaz saschanaz changed the title Remove never-supported CSS Mask properties Add notes for unimplemented CSS mask-origin keywords Feb 21, 2021
Base automatically changed from master to main March 24, 2021 12:54
ddbeck
ddbeck requested changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why I let this sit around so long. Sorry about that, @saschanaz.

If they're going to stick around in the spec, then my only suggestion here is: can we flag these features as experimental? No implementations implies that, I think.

ddbeck
ddbeck approved these changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit 00049e0 into mdn:main Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelandrew rachelandrew rachelandrew left review comments

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschanaz @ddbeck @rachelandrew @queengooborg